[core] format table: support file compression and custom default for diff format #6500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces automatic file compression configuration for format tables based on their file format type. Instead of requiring users to explicitly set 'file.compression'='none' in table properties, the system now automatically determines appropriate compression defaults: none for CSV/JSON, snappy for Parquet, and zstd for ORC.
Key changes:
- Added
FORMAT_TABLE_FILE_COMPRESSIONconfig option with fallback toFILE_COMPRESSION - Implemented
getFormatTableFileCompression()utility method to determine compression based on format - Updated catalog implementations (HiveCatalog, RESTCatalog) to auto-populate file compression during table creation
- Removed explicit
'file.compression'='none'declarations from test cases
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| paimon-api/src/main/java/org/apache/paimon/CoreOptions.java | Added FORMAT_TABLE_FILE_COMPRESSION config option and formatTableFileImplementation() method |
| paimon-core/src/main/java/org/apache/paimon/catalog/CatalogUtils.java | Implemented getFormatTableFileCompression() with format-specific defaults |
| paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java | Auto-set file compression during format table creation |
| paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java | Auto-set file compression during format table creation |
| paimon-core/src/main/java/org/apache/paimon/table/format/FormatTableFileWriter.java | Updated to use formatTableFileImplementation() instead of fileCompression() |
| paimon-core/src/test/java/org/apache/paimon/catalog/CatalogTestBase.java | Added test coverage for format-specific file compression defaults |
| paimon-spark/paimon-spark-ut/src/test/scala/org/apache/paimon/spark/table/PaimonFormatTableTest.scala | Removed explicit file compression settings from test cases |
| paimon-spark/paimon-spark-ut/src/test/scala/org/apache/paimon/spark/sql/FormatTableTestBase.scala | Removed explicit file compression settings from test cases |
| paimon-spark/paimon-spark-ut/src/test/java/org/apache/paimon/spark/SparkCatalogWithHiveTest.java | Removed explicit file compression settings from test cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jerry-024
force-pushed
the
format_table_compression
branch
from
7fa9a60 to
94207bd
Compare
jerry-024
changed the title
jerry-024
force-pushed
the
format_table_compression
branch
from
37cef85 to
e05a60d
Compare
jerry-024
force-pushed
the
format_table_compression
branch
from
e05a60d to
f781e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
format table: support file compression and custom default for diff format
Tests
API and Format
Documentation